Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting editor list item overflow #206681

Merged

Conversation

hsfzxjy
Copy link
Contributor

@hsfzxjy hsfzxjy commented Mar 2, 2024

Fix #206333

@hsfzxjy hsfzxjy force-pushed the setting-editor-item-overflow-206333 branch from ddf6c5a to ab4c384 Compare March 6, 2024 13:47
@rzhao271
Copy link
Contributor

rzhao271 commented Mar 8, 2024

I'd like to confirm that when there is an overflow, does a screenreader such as NVDA still read the full text?

@hsfzxjy
Copy link
Contributor Author

hsfzxjy commented Mar 9, 2024

As I tested on Linux with Orca screen reader, it did read out the full text.

@rzhao271 rzhao271 added this to the March 2024 milestone Mar 11, 2024
@rzhao271 rzhao271 enabled auto-merge (squash) March 11, 2024 18:04
@rzhao271 rzhao271 merged commit 0db502e into microsoft:main Mar 11, 2024
6 checks passed
@hsfzxjy hsfzxjy deleted the setting-editor-item-overflow-206333 branch March 11, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long string items overflow controls in Settings UI.
3 participants