Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit splits of = for environment variables. #207889

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Limit splits of = for environment variables. #207889

merged 1 commit into from
Mar 15, 2024

Conversation

DanielRosenwasser
Copy link
Member

This PR fixes #197603. Only the bash and PowerShell files have been touched. From what I understand, the zsh one is already correct in its behavior.

The current behavior is makes for a pretty painful and confusing experience for Python developers since .env is automatically loaded up, and it's not clear where it comes from.

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Tyriar Tyriar added this to the March 2024 milestone Mar 15, 2024
@Tyriar Tyriar self-assigned this Mar 15, 2024
@Tyriar Tyriar enabled auto-merge March 15, 2024 21:42
@Tyriar Tyriar merged commit e8fd06f into main Mar 15, 2024
7 checks passed
@Tyriar Tyriar deleted the limitSplit branch March 15, 2024 21:44
chen-ky pushed a commit to chen-ky/vscode that referenced this pull request Mar 18, 2024
Limit splits of `=` for environment variables.
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment collection replace API strips equals sign at the end
2 participants