Detect ghost text in PromptInputModel #210690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amunger
approved these changes
Apr 18, 2024
meganrogge
reviewed
Apr 18, 2024
| @@ -122,9 +144,15 @@ export class PromptInputModel extends Disposable implements IPromptInputModel { | |||
| // Get cursor index | |||
| const absoluteCursorY = buffer.baseY + buffer.cursorY; | |||
| this._cursorIndex = absoluteCursorY === commandStartY ? this._getRelativeCursorIndex(this._commandStartX, buffer, line) : commandLine.length + 1; | |||
| this._ghostTextIndex = -1; | |||
|
|
|||
| // Detect ghost text by looking for italic or dim text in or after the cursor and | |||
There was a problem hiding this comment.
this is cool, wouldn't have thought of this
|
This is how I've been detecting ghost text since I've seen variation between |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #210662
Ghost text will show up in brackets in the devmode status bar:
I tested this on PowerShell but it should work on any shell that uses dim or italic as ghost text.
cc @cpendery