Add /** */ to cpp/language-configurations.json

[sean-mcmanus]

Fixes microsoft/vscode-cpptools#12249 .

This was removed in 98fa77a .

Then PR #160357 added /* */ autoClosingPair.

[sean-mcmanus]

@bobbrow @Colengms Is there any issue with this?

[sean-mcmanus]

@bobbrow I talked this over with Colen -- this causes users with setting "C_Cpp.doxygen.generatedStyle": "/**" to not get onType doxygen generation. Is that okay or what?

[bobbrow]

@bobbrow I talked this over with Colen -- this causes users with setting "C_Cpp.doxygen.generatedStyle": "/**" to not get onType doxygen generation. Is that okay or what?

If the user has that setting set, can we replace the language configuration with one that doesn't specify /** and make it work?

[sean-mcmanus]

If the user has that setting set, can we replace the language configuration with one that doesn't specify /** and make it work?

@bobbrow We can? How? Even if users have the generationStyle set to /**, they'd still get the buggy indentation for comments that are not before a declaration which auto-generates doxygen, i.e. in a function.

It's possible our doxygen generation could be fixed by looking for the */ change and then looking if the characters beforehand are /** -- it currently only looks for /**.

[sean-mcmanus]

@bobbrow I have a PR/fix for Doxygen comment generation that handles the /** */ case that results from this change.

UPDATE: The fix PR is in for 1.21.0.

[sean-mcmanus]

@alexr00 What's the timeline on getting this reviewed?

[alexr00]

@sean-mcmanus can you walk me through what has changed since #77008 (comment) that makes this change better now?

[sean-mcmanus]

@sean-mcmanus can you walk me through what has changed since #77008 (comment) that makes this change better now?

@alexr00 Yeah, VS Code added the editor.autoClosingComments setting. Also, we fixed an issue with our Doxygen generation code for our next release. So, our team isn't aware of any downside to this change.

[sean-mcmanus]

@sean-mcmanus can you walk me through what has changed since #77008 (comment) that makes this change better now?

@alexr00 Yeah, VS Code added the editor.autoClosingComments setting. Also, we fixed an issue with our Doxygen generation code for our next release. So, our team isn't aware of any downside to this change.

Also, after that comment was made, we added the /**/ completion: see #160357 .

[alexr00]

Looks good, thank you!