Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move terminal icon picker position to relevant terminal tab #212174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

albarv340
Copy link

Fixes #211083
This moves the icon picker to always point to the terminal being affected by the icon change. If triggered via the command palette, the active tab is pointed to, since it is the one changing. If triggered via the terminal tab, it points to the terminal tab that is being changed.

Examples:
Change Icon was clicked on bash 1:
image

Triggered via action bar with bash 3 active:
image

@albarv340
Copy link
Author

@microsoft-github-policy-service agree

@abhijit-chikane
Copy link
Contributor

abhijit-chikane commented May 7, 2024

Well the question is if i try to update the color it opens up at the top and if I try to update the icon it is opening near the terminal tab, why two different choices?

@Narendherraj
Copy link

Like @abhijit-chikane has expressed his concern we should probably change the position of the terminal icon colour change tab as well if not it might look weird where one shows the position on bottom and the other on top .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terminal Icon picker weird placement
4 participants