It also looks like the octicon text also shows up in the hover tooltips (title attr)

Any chance to get this on the list for the June (or soon) iteration? This does seem to cause confusion for users as they have no idea what that text that all of a sudden appears is.

Maybe a code position where we could dig in?

The picker is opened from here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/quickopen/quickOpenController.ts#L219

Thanks, I'll take a look, but I was never that deep in the code. :/

@eamodio maybe you check the fix out on master with GitLens since you are a heavy customer.

Will do - thanks!

@bpasero I just checked out master and I don't see any tooltips on quickpick items now.

I did notice another issue (not new though), the tooltip over the input (for the placeholder), shows the wrong content (previous content) if the quickpick is replaced with a new one.

For example, in GitLens if you open file or branch history in a quickpick and see the tooltip over the input (it should be correct), but then pick one of the commits (which will open a new quickpick), and see that the tooltip over the input it still showing the previous tooltip content, not the updated content. (FYI, this is not new, I can reproduce it in 1.19 too)

@eamodio can you file separate issues for that? To be clear: this issue is resolved for you right?

@bpasero No -- now I don't see any tooltips at all -- I was expecting that the octicons would be stripped, but now there is no tooltip at all.

Will do, re: other issue.

Opened: #43114 for the other issue

Sorry, I was getting mixed up on this. The search part works great now -- octicons don't show up

adding verified label based on @eamodio's comment