Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color theme preview not working with "window.systemColorTheme": "auto" #213539

Merged
merged 1 commit into from
May 27, 2024
Merged

Color theme preview not working with "window.systemColorTheme": "auto" #213539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/vs/workbench/services/themes/browser/workbenchThemeService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,11 @@ export class WorkbenchThemeService extends Disposable implements IWorkbenchTheme
// preferred scheme handling

private installPreferredSchemeListener() {
this._register(this.hostColorService.onDidChangeColorScheme(() => this.restoreColorTheme()));
this._register(this.hostColorService.onDidChangeColorScheme(() => {
if (this.settings.isDetectingColorScheme()) {
this.restoreColorTheme();
}
}));
}

public hasUpdatedDefaultThemes(): boolean {
Expand Down
4 changes: 4 additions & 0 deletions src/vs/workbench/services/themes/common/themeConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,10 @@ export class ThemeConfiguration {
return undefined;
}

public isDetectingColorScheme(): boolean {
return this.configurationService.getValue(ThemeSettings.DETECT_COLOR_SCHEME);
}

public getColorThemeSettingId(): ThemeSettings {
const preferredScheme = this.getPreferredColorScheme();
return preferredScheme ? colorSchemeToPreferred[preferredScheme] : ThemeSettings.COLOR_THEME;
Expand Down
Loading