Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add disposable to elementDisposables instead of templateDisposables in renderElement function in SettingEnumRenderer #216855

Merged

Conversation

SimonSiefke
Copy link
Contributor

Helps with #216649

In SettingEnumRenderer, the renderElement function calls the renderValue function, whichs adds disposables to the template disposables instead of the element disposables.

It seems the disposables in renderValue should always be added to elementDisposables:

function name disposables
renderTemplate template disposables
renderElement element disposables
renderValue element disposables

…les in renderElement function in SettingEnumRenderer
@rzhao271 rzhao271 added this to the June 2024 milestone Jun 24, 2024
@rzhao271 rzhao271 merged commit 14b094b into microsoft:main Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants