Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure to rerender requests after attaching variable data #221482

Merged
merged 1 commit into from
Jul 11, 2024
Merged

make sure to rerender requests after attaching variable data #221482

merged 1 commit into from
Jul 11, 2024

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Jul 11, 2024

  • emit event (via the parent chat model)
  • compute dataId considering the variable data

fyi @roblourens

@jrieken
make sure to rerender requests after attaching variable data
33bd171 
* emit event (via the parent chat model)
* compute dataId considering the variable data

fyi @roblourens
@jrieken jrieken self-assigned this Jul 11, 2024
@jrieken jrieken enabled auto-merge (squash) July 11, 2024 16:03
@VSCodeTriageBot VSCodeTriageBot added this to the July 2024 milestone Jul 11, 2024
@jrieken jrieken mentioned this pull request Jul 11, 2024
Closed
@jrieken jrieken merged commit 067c430 into main Jul 11, 2024
7 checks passed
@jrieken jrieken deleted the joh/conservation-louse branch July 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyceerhl joyceerhl joyceerhl approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
July 2024
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrieken @joyceerhl @VSCodeTriageBot