Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate debug.autoExpandLazyVariables to enum format, enable it by default for screen reader users #221513

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Jul 11, 2024

@meganrogge meganrogge self-assigned this Jul 11, 2024
@meganrogge meganrogge added this to the July 2024 milestone Jul 11, 2024
@meganrogge meganrogge enabled auto-merge (squash) July 11, 2024 21:36
@meganrogge meganrogge merged commit edf1ce0 into main Jul 11, 2024
6 checks passed
@meganrogge meganrogge deleted the merogge/auto-setting branch July 11, 2024 21:53
nls.localize('debug.autoExpandLazyVariables.on', "Always automatically expand lazy variables."),
nls.localize('debug.autoExpandLazyVariables.off', "Never automatically expand lazy variables.")
],
description: nls.localize('debug.autoExpandLazyVariables', "Controls if variables, such as getters, are automatically resolved and expanded by the debugger.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "variables that are lazily resolved" was an important part of this description

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion: #221752

roblourens added a commit that referenced this pull request Jul 15, 2024
roblourens added a commit that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

by default, auto expand variables when debugging in screen reader mode
3 participants