Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ArraySet #25780

Closed
jrieken opened this issue May 2, 2017 · 1 comment
Closed

Remove ArraySet #25780

jrieken opened this issue May 2, 2017 · 1 comment
Assignees
@sandy081
Labels
debt Code quality issues
Milestone
June 2017

Comments

@jrieken
Copy link
Member

jrieken commented May 2, 2017

We have an ArraySet in our code base which isn't needed given that we can use native sets these days. In the name of less bloat and a smaller code base it should be removed
@jrieken jrieken added the debt Code quality issues label May 2, 2017
@joaomoreno joaomoreno added this to the Backlog milestone May 4, 2017
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno May 4, 2017
@joaomoreno
Copy link
Member

joaomoreno commented May 4, 2017 •
edited

Passing the ball to remove the references to ArraySet. Last one deletes it.

This is gonna be such a perf improvement. ⚡️

joaomoreno added a commit that referenced this issue May 4, 2017
@joaomoreno
remove references to ArraySet
36c491e 
related to #25780
@bpasero bpasero modified the milestones: May 2017, Backlog May 4, 2017
@bpasero bpasero assigned sandy081 and unassigned bpasero May 5, 2017
@bpasero bpasero removed this from the May 2017 milestone May 5, 2017
@sandy081 sandy081 added this to the June 2017 milestone May 31, 2017
@stringham stringham mentioned this issue Jun 28, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues
Projects
None yet
Milestone
June 2017
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @jrieken @sandy081