Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make extension list in generated issue shorter #28012

Merged
merged 3 commits into from
Jun 14, 2017
Merged

Make extension list in generated issue shorter #28012

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acfc6b6
Skip unnecessary |s in extension list for #27987
roblourens Jun 5, 2017
2e61830
Exclude extensions that only contribute themes from the extension lis…
roblourens Jun 5, 2017
e3589e9
Truncate publisher name in extension list #27987
roblourens Jun 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/vs/workbench/electron-browser/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
'use strict';

import URI from 'vs/base/common/uri';
import * as collections from 'vs/base/common/collections';
import { TPromise } from 'vs/base/common/winjs.base';
import { Action } from 'vs/base/common/actions';
import { IWindowIPCService } from 'vs/workbench/services/window/electron-browser/windowService';
Expand Down Expand Up @@ -721,21 +722,33 @@ Steps to Reproduce:
}

private generateExtensionTable(extensions: ILocalExtension[]): string {
const { nonThemes, themes } = collections.groupBy(extensions, ext => {
const manifestKeys = ext.manifest.contributes ? Object.keys(ext.manifest.contributes) : [];
const onlyTheme = !ext.manifest.activationEvents && manifestKeys.length === 1 && manifestKeys[0] === 'themes';
return onlyTheme ? 'themes' : 'nonThemes';
});

const themeExclusionStr = themes.length ? `\n(${themes.length} theme extensions excluded)` : '';
extensions = nonThemes;

if (!extensions.length) {
return 'none';
return 'none' + themeExclusionStr;
}

let tableHeader = `|Extension|Author|Version|
|---|---|---|`;
let tableHeader = `Extension|Author (truncated)|Version
---|---|---`;
const table = extensions.map(e => {
return `|${e.manifest.name}|${e.manifest.publisher}|${e.manifest.version}|`;
return `${e.manifest.name}|${e.manifest.publisher.substr(0, 3)}|${e.manifest.version}`;
}).join('\n');

const extensionTable = `

${tableHeader}\n${table};
${tableHeader}
${table}
${themeExclusionStr}

`;

// 2000 chars is browsers de-facto limit for URLs, 400 chars are allowed for other string parts of the issue URL
// http://stackoverflow.com/questions/417142/what-is-the-maximum-length-of-a-url-in-different-browsers
if (encodeURIComponent(extensionTable).length > 1600) {
Expand Down