Extension install count, use current locale for number formatting Fixes #29491

[cleidigh]

See #29491 for discussion
sorry had to squash commits

[cleidigh]

@sandy081
Just want to check if this one liner is okay to close out.
Cheers

[Tyriar]

Ping @sandy081, not sure if we want to do this for German (#29491 (comment)).

[cleidigh]

@sandy081
Do you have an opinion on whether to use appropriate locale format or commas always?

[sandy081]

@cleidigh Sorry for the delay.

Is there a reason why not using toLocaleString api?

[Hirse]

Does toLocaleString require a locale in this case or would it default to the correct one?
It one is required, how would the correct locale be retrieved?

I put the original comment because this looked wrong to me:

installLabel = installCount.toLocaleString('en');

[cleidigh]

@sandy081
No problem, I know you guys are busy with the multi-root stuff , great new addition!

@Hirse / @sandy081
My inclination was to use platform.locale thus using the correct number formatting for any locale.
I did the PR just using the English locale (always commas) given others comments on simplicity.
I can change it to:

installLabel = installCount.toLocaleString(platform.locale);

[sandy081]

@cleidigh Yeah, using the locale makes sense to me. Can you please change it accordingly? Thanks.

[cleidigh]

@sandy081
Done.
Sorry for the protracted discussion on a one liner !

[sandy081]

LGTM. Thanks for the PR.