Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reordering of views in split view by drag and drop #30197

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Support reordering of views in split view by drag and drop #30197

merged 1 commit into from
Jul 7, 2017

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented Jul 6, 2017

Re #30120

This will support drag and drop of views in Split view to re-order them.

kapture 2017-07-06 at 18 05 15

@sandy081 sandy081 requested a review from joaomoreno July 6, 2017 16:06
joaomoreno
joaomoreno requested changes Jul 7, 2017
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, just like you!!!

Maybe let's use a drag image similar to tree view. Also consider introducing visual splitters so it becomes clear to the user where the view will end up. Also, beware of the void view corner case.

@sandy081
Copy link
Member Author

sandy081 commented Jul 7, 2017

Thanks for the feedback. As discussed will adopt the feedback after merging.

@sandy081 sandy081 merged commit 119513f into master Jul 7, 2017
@sandy081 sandy081 deleted the sandy081/viewsDragAndDrop branch July 7, 2017 09:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno requested changes

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sandy081 @joaomoreno @msftclas