Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css at-rule support for auto-complete #304

Merged
merged 6 commits into from
Nov 20, 2015
Merged

Update css at-rule support for auto-complete #304

merged 6 commits into from
Nov 20, 2015

Conversation

dstorey
Copy link
Member

@dstorey dstorey commented Nov 20, 2015

I’ve not included the at-rules that are not yet supported.

@msftclas
Copy link

Hi @dstorey, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (David Storey). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

aeschli added a commit that referenced this pull request Nov 20, 2015
Update css at-rule support for auto-complete
@aeschli aeschli merged commit 9159003 into microsoft:master Nov 20, 2015
@aeschli
Copy link
Contributor

aeschli commented Nov 20, 2015

The build failure comes from a hiccup in the build, the pull request is fine.
However, to get the changes in VS Code , the 'generate_browserjs.js' script needs to be run. This will generate browsers.js from the xml file. I'll do that. Thanks @dstorey !

@aeschli
Copy link
Contributor

aeschli commented Nov 20, 2015

Note: the @viewport rule will not show up in browsers.js as it is marked browsers="none"

aeschli added a commit that referenced this pull request Nov 20, 2015
@dstorey dstorey deleted the update-css-at-rule-support branch November 20, 2015 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants