Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running a launch config with a missing "request" attribute fails silently #31197

Closed
weinand opened this issue Jul 21, 2017 · 8 comments
Closed

Running a launch config with a missing "request" attribute fails silently #31197

weinand opened this issue Jul 21, 2017 · 8 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verification-found Issue verification failed verified Verification succeeded
Milestone
October 2017

Comments

@weinand
Copy link
Contributor

weinand commented Jul 21, 2017

I was just bitten by this:
Running a debug session that is missing the "request" attribute fails silently and the only indication is the tiny green squiggly:

2017-07-21_11-20-23

Since the "request" attribute is mandatory I suggest that we show an error notification like the one for an unknown debug type.

2017-07-21_11-34-45
@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 21, 2017
@weinand weinand added this to the September 2017 milestone Sep 5, 2017
@isidorn isidorn closed this as completed in 40af684 Sep 8, 2017
@roblourens
Copy link
Member

I don't see an error message

  • Open vscode workspace
  • Delete 'request' line from "Launch VS Code"
  • Try to start the launch config
  • Nothing happens

@roblourens roblourens reopened this Sep 27, 2017
@roblourens roblourens added the verification-found Issue verification failed label Sep 27, 2017
@weinand
Copy link
Contributor Author

weinand commented Sep 28, 2017

I get the error message if the "request" attribute is missing:

2017-09-28_10-33-26

However, I do not like the wording: What exactly is a "debug request"?

I recommend:
"Attribute 'request' is missing from the chosen debug configuration."

(Make sure that 'request' is not translated by nls by adding it as an message argument)

@isidorn
Copy link
Contributor

isidorn commented Sep 28, 2017

@roblourens nice catch. However this only does not work for that chrome corner case, since chrome is contributing a startSessionCommand and in that case we do not do the request check.
This will be handled in october via #33791
Due to that closing

@isidorn isidorn closed this as completed Sep 28, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 28, 2017

@weinand thanks for feedback, will update the message

isidorn added a commit that referenced this issue Sep 28, 2017
@isidorn
fixes #31197
e522601
@weinand weinand added the verified Verification succeeded label Sep 29, 2017
@weinand
Copy link
Contributor Author

weinand commented Nov 1, 2017

Reopening because there is still no error message after #33791 has been closed.

@weinand weinand reopened this Nov 1, 2017
@weinand weinand removed the verified Verification succeeded label Nov 1, 2017
@weinand weinand modified the milestones: September 2017, October 2017 Nov 1, 2017
@isidorn
Copy link
Contributor

isidorn commented Nov 1, 2017

@weinand good catch

@isidorn isidorn closed this as completed in ee32d67 Nov 1, 2017
weinand added a commit that referenced this issue Nov 2, 2017
@weinand
fixed quotes (for #31197)
b4d7531
@weinand
Copy link
Contributor Author

weinand commented Nov 2, 2017

Verified!

But please don't use backticks when quoting arguments or attributes:

2017-11-02_11-02-44

I've fixed that.

@weinand weinand added the verified Verification succeeded label Nov 2, 2017
@weinand
Copy link
Contributor Author

weinand commented Nov 2, 2017

The error still does not show up if a debug session is launched from the status line.
I've created #37507 for this.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
3 participants
@roblourens @weinand @isidorn