Enable regex's ^, $ and ^$ to be matched in file dialog #314
Conversation
|
Hi @Tyriar, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
Find and replace /^/
Find and replace /$/
Find and replace /^$/
|
|
@Tyriar, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Looks awesome. |
| do { | ||
| m = searchRegex.exec(text); | ||
| if (m) { | ||
| result.push(new Range(lineNumber, m.index + 1 + deltaOffset, lineNumber, m.index + 1 + m[0].length + deltaOffset)); | ||
| var range = new Range(lineNumber, m.index + 1 + deltaOffset, lineNumber, m.index + 1 + m[0].length + deltaOffset); |
There was a problem hiding this comment.
Why use var in TS when let and const are available?
There was a problem hiding this comment.
Because const and let are not used in the file yet `var is extensively and there's not mention in the coding guidelines.
There was a problem hiding this comment.
Lots of code was written before TypeScript added support for let. We didn't do a full pass to replace all usages
|
@Tyriar This is great! Thank you so much! ❤️ |
Enable regex's ^, $ and ^$ to be matched in file dialog
|
Guys i Want the oposite of that if i want to find this pattern }{ nad i want to make line break like I have this{"index":{"_id":0}},{"index":{"_id":0}} And i want this{"index":{"_id":0}} is any wat to filter for |
|
@atlabiz
|
Fixes #278