Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: logo does not have a specific background #33362

Closed
bpasero opened this issue Aug 29, 2017 · 5 comments
Closed

Windows: logo does not have a specific background #33362

bpasero opened this issue Aug 29, 2017 · 5 comments
Assignees
@bpasero @chrisdias
Labels
icon-brand VS Code brand icon issues
Milestone
September 2017

Comments

@bpasero
Copy link
Member

bpasero commented Aug 29, 2017 •
edited

We should follow up if the logo on Windows startmenu should also have a specific background set (like the VS one). Currently it seems to use the default blue color.

logo
@bpasero bpasero added the icon-brand VS Code brand icon issues label Aug 29, 2017
@bpasero bpasero modified the milestone: August 2017 Aug 29, 2017
@bpasero bpasero mentioned this issue Aug 29, 2017
Closed
@qpegg
Copy link

qpegg commented Aug 29, 2017

I have wanted this. Thanks!

@bpasero bpasero mentioned this issue Aug 29, 2017
Closed
@isidorn
Copy link
Contributor

isidorn commented Aug 29, 2017

When installing VSCode on windows I get the white background during the installation process which actually looks good. Which makes me believe that the person designing the icon had only white background in mind

screen shot 2017-08-29 at 16 57 48

@ghiscoding
Copy link

@isidorn just a thought but the white background might pop out too much when using Windows 10 dark theme. On a light theme it makes perfect sense though. I'm on a dark theme and the only icon I have with a white background is Opera.

@bpasero bpasero mentioned this issue Aug 30, 2017
Closed
@gbale
Copy link

gbale commented Aug 30, 2017

+1 and this should help:
https://msdn.microsoft.com/en-us/library/windows/apps/xaml/dn449733.aspx

@dominicfallows
Copy link

Perhaps related to some thoughts here #6607 #issuecomment-325998918 ?

@bpasero bpasero modified the milestones: August 2017, September 2017 Aug 31, 2017
@bpasero bpasero closed this as completed in 9fa0a77 Sep 5, 2017
@bramborman bramborman mentioned this issue Sep 28, 2017
Closed
48 tasks
@mattacosta mattacosta mentioned this issue Oct 20, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@bpasero
Windows: logo does not have a specific background (fixes microsoft#33362
8343688 
)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@chrisdias chrisdias

Labels
icon-brand VS Code brand icon issues
Projects
None yet
Milestone
September 2017
Development

No branches or pull requests
7 participants
@dominicfallows @ghiscoding @bpasero @chrisdias @isidorn @gbale @qpegg