-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal can crash VS Code on Windows #34301
Comments
Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders |
For how long? |
The timing wasn't uniform. |
I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: |
I tried that but the problem still persists. |
I'm trying to use the git bash terminal for the |
Adding @Tyriar |
I believe this is a duplicate of #34039 which is fixed in 1.16.1 (and Insiders). Did you try on the latest Insiders build? It wasn't clear from your comment. |
Looks like the crash is caused by windows-process-tree. I have a guess as to what causes it; computers having more than 1024 causing an access violation as the process info is collected into a |
Upstream issue: microsoft/vscode-windows-process-tree#9 |
Reliable repro is to just keep creating new powershell sessions, my PC crashes at around 40. |
The issue is fixed in windows-process-tree@0.1.6 e6874a3 There were two potential crashes fixed:
|
Happening again after update to Code x32 1.16.1, terminal is crashing the code again, on Win 7 SP1 Enterprize x64, while running any longer script but mostly on grunt build or grunt run. Our stack is npm (6.11.x) + grunt + angular 4 app. Also mostly by having 2 terminals in the same time, but not only then. Because we love Code so much and all the effort put in it, we want to greet the VS Code Team, and help by spreading good word about the Code, it is (including MS Visual Studio and TypeScript) one of the best products MS ever made :) Keep up the good work and thank you all. |
Same behavior here, tested with a load of CLI , sometimes it crashes instantly, sometimes it doesn't with the exact same CLI.
|
I'm testing the |
Crashing started for me a couple of days ago, on 1.16.0 . Also while running terminals. |
Just to clarify the situation if this can help, the crash of Code happens only while using multiple terminals (more than 1), the update 1.16.1 didn't change this behavior at all. So while using single terminal everything works fine. Hope it helps, greetings to Code Team. |
This never ended up making it into a 1.16.2 as I've been out. Unfortunately you will need to wait until 1.17.0 for the fix. |
There seems to be a few of these crashes reported against 1.17.0-insiders still but these are likely people not updating. There was a steep decline around the time that I made the fix 👍 |
I also get this issue intermittently when I do npm run webpack from an integrated terminal with npm run start in another integrated terminal. Where webpack runs webpack -w and start runs nodemon All I do is save a file, the file watcher (-w) picks up the change and vscode crashes as webpack tries to do its thing. Also, annoyingly, the node.exe processes that were started in the terminal (by way of npm) continue to run even after code.exe has crashed, and there's no way to get back to the terminal to ctrl-c it and I have to kill the node process from task manager. I would expect that process started in the integrated terminal would be part of a job that would be terminated when vscode exits. (But it appears that the process breaks away, since it didn't terminate along with code.exe) (Windows 10 x64)
|
Its Working Now 👍 !! Thank you @Tyriar and complete VS Code Team, this is now fixed in 1.17 and VS Code is working excellent on Win platform :) We want just to help you so you can close all other bugs related to this, terminal is not crashing anymore, and is much faster. Keep up the good work and thank you on this software (VS Studio meets Sublime) |
@pozzito awesome, great to hear! 😃 |
Hi, not sure if this is related, so I haven't opened a new bug yet, but I'm encountering a full system freeze on Windows 10 after I wake my computer in the morning and click on VS Code. VS Code was already open, I was just switching to it by clicking on the Taskbar icon. I've been encountering full system freezes on my work machine for several months now. I've gone through 4 machines at work trying to figure out what the problem is, but after the release of 1.17.x, it seems clearer that VS Code appears to be the culprit. This has happened to me two days in a row now (ever since I upgraded to 1.17.2). I've noticed that I get a
There's also a
|
Please disregard my previous comment. I've asked the same question in #35590 instead |
Steps to Reproduce:
Reproduces without extensions: Yes/No
The text was updated successfully, but these errors were encountered: