Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal link detection only works after scrolling #36072

Closed
coreh opened this issue Oct 11, 2017 · 13 comments
Closed

Terminal link detection only works after scrolling #36072

coreh opened this issue Oct 11, 2017 · 13 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@coreh
Copy link

coreh commented Oct 11, 2017

  • VSCode Version: 1.17.0
  • OS Version: OS X 10.12.6

Steps to Reproduce:

  1. On the terminal, run a command that outputs a URL
  2. Hover the link with the mouse. VSCode will not recognize it as clickable
  3. Scroll the terminal up/down
  4. VSCode will now recognize the link and Cmd+Click will work

Also tested on Windows 10, same results.

Edit: Just got the 1.17.1 update, the bug is still present

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Oct 11, 2017
@Tyriar
Copy link
Member

Tyriar commented Oct 28, 2017

This was mostly fixed in 1.17.1 (#35662) but it occasionally still doesn't work.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Oct 28, 2017
@Tyriar Tyriar added this to the Backlog milestone Oct 28, 2017
@scorredoira
Copy link

I am using 1.17.2 and the problem is still present.
Also after scrolling the problem disappears.

@Tyriar
Copy link
Member

Tyriar commented Oct 30, 2017

Was the terminal hidden before hovering the link? If so this could be #37103

@scorredoira
Copy link

scorredoira commented Oct 30, 2017

No, it was visible all the time. Also I checked for errors in the Developer Tools Console and has none.
And scrolling just a little makes it work again.

@scorredoira
Copy link

It seems totally random. I'm doing all kind of tests to reproduce it but I can't find a pattern.

@scorredoira
Copy link

It's also present in Version 1.18.0-insider. I have done now ~50 tests and it is random.

@coreh
Copy link
Author

coreh commented Oct 31, 2017

It's not happening randomly for me, I get it consistently every single time

@gwk
Copy link

gwk commented Nov 2, 2017

@scorredoira @coreh my experience (with file paths, not urls) is that it seems reproducible, and has to do with the the terminal buffer filling up enough to scroll. However just a couple of times I didn't quite see what I was expecting, so I'm not sure if the bug is totally deterministic. Are you able to see the same behavior as I described in #37453?

@scorredoira
Copy link

@gwk my experience is also with file paths. The behavior I see like #37453 but only about 10-20% of the times

@scorredoira
Copy link

scorredoira commented Nov 2, 2017

I thought I had narrowed it and that links only stopped working the moment there was enough content for the scrollbar to appear. I did multiple tests with a fresh terminal each time. It behaved that way for 5 or 6 times but then It started to fail the first link and not the following until the scroll kicked in. Worked the same way a few times and the a different pattern. So it is definitely random for me.

In case it helps, when I see a pattern it repeats itself for a few times and then it changes.

@coreh
Copy link
Author

coreh commented Nov 3, 2017

One interesting thing that I noticed is that even links that were previously correctly detected as URLs (by scrolling up/down) stop working as soon as a new line gets added, even if that newline doesn't itself contain any links.

Using something like tmux (that hijacks the new line command and instead draws characters at specific positions via curses) completely bypasses the issue.

@Tyriar
Copy link
Member

Tyriar commented Dec 12, 2017

Using something like tmux (that hijacks the new line command and instead draws characters at specific positions via curses) completely bypasses the issue.

This is probably the case because tmux never actually scrolls. Scrolling within tmux just redraws the viewport.

@Tyriar
Copy link
Member

Tyriar commented Jan 22, 2018

I think I found the fix xtermjs/xterm.js#1234

@Tyriar Tyriar closed this as completed in 80991ce Jan 22, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants