Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototyping new CodeAction API #36316

Merged
merged 6 commits into from
Nov 9, 2017
Merged

Prototyping new CodeAction API #36316

merged 6 commits into from
Nov 9, 2017

Commits on Nov 8, 2017

  1. Add CodeAction Type 

    Adds skeleton on a new CodeActionType and allows codeActionProvider to return either `Command`s or `CodeAction`s

Move proposed CodeAction API to proposed and try using it in TS

Split CodeAction into quickfix and refactoring classes

Update proposed interface

Update for new API

Adding basic docs
    @mjbvz
    mjbvz committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    973443f View commit details
    Browse the repository at this point in the history

  2. Support workspace edits and text edits in codeactions

    @mjbvz
    mjbvz committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    b52ec8c View commit details
    Browse the repository at this point in the history

  3. Remove placeholders

    @mjbvz
    mjbvz committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    f88dc40 View commit details
    Browse the repository at this point in the history

  4. Resolving conflicts and making PR suggested changes

    @mjbvz
    mjbvz committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    608026c View commit details
    Browse the repository at this point in the history

  5. Fix quick fix test

    @mjbvz
    mjbvz committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    f1e6cdd View commit details
    Browse the repository at this point in the history

  6. Revert change to only use CodeAction instead of `CodeAction | Comma… 

    …nd` in modes since this will break `vscode.executeCodeActionProvider`
    @mjbvz
    mjbvz committed Nov 8, 2017
    Configuration menu
    Copy the full SHA
    19cae05 View commit details
    Browse the repository at this point in the history