Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isidorn/vertical panel #36827

Merged
merged 14 commits into from
Oct 25, 2017
Merged

Isidorn/vertical panel #36827

merged 14 commits into from
Oct 25, 2017

Conversation

isidorn
Copy link
Contributor

@isidorn isidorn commented Oct 24, 2017

This PR adds the vertical panel.

As part of this I have also:

  • Restructured old layout code
  • improved min and max boundary computations
  • removed the ToggleMaximizedPanelAction - the reason for this is that the action was damn ugly to implement and I believe the vertical panel will be a fine alternative to this (especialy since I store size per panel position, so a user can have a vertical panel very large and a horizontal quite tiny, so he can also swithc to vertical when in need of more space)
  • am using a VS icon for the action currently. For a better icon I would need help from @chryw

@isidorn isidorn added this to the October 2017 milestone Oct 24, 2017
@isidorn isidorn merged commit 7dec12f into master Oct 25, 2017
@isidorn isidorn deleted the isidorn/vertical_panel branch October 25, 2017 10:56
@suciuvlad
Copy link

It's pretty annoying that "ToggleMaximizedPanelAction" was removed actually 👎 . I'm coming from a tmux vim setup where i have the screen split into two(line length set to 80 chars) and the terminal always open at the bottom. http://d.pr/i/Vxp7QN It's very hard to read the terminal in full height now.

@isidorn
Copy link
Contributor Author

isidorn commented Oct 27, 2017

@suciuvlad it's back now. check out latest insiders

@suciuvlad
Copy link

@isidorn Thanks!

@contention
Copy link

@isidorn - Thanks... appreciate the work you've done on this. Been waiting for this PR a while and it makes a big and positive difference, at least to my own workflow. :o)

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants