Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTRL+F2 highlights occurrences on scrollbar only downwards #38088

Closed
turboborsuk opened this issue Nov 10, 2017 · 5 comments
Closed

CTRL+F2 highlights occurrences on scrollbar only downwards #38088

turboborsuk opened this issue Nov 10, 2017 · 5 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
November 2017

Comments

@turboborsuk
Copy link

When using CTRL+F2 to select all occurrences of a string all of them are selected within the file but the scrollbar feedback is limited to only those starting from current selection and downward.

  • VSCode Version: 1.18.0
  • OS Version: Windows 10 1703

Steps to Reproduce:

  1. Open a reasonably long file with multiple occurrences of a specific string
  2. Select a string occurrence somewhere in the middle
  3. Observe tickmarks on scrollbar missing until current selection.
@alexdima
Copy link
Member

Duplicate of #1110

@alexdima alexdima marked this as a duplicate of #1110 Nov 13, 2017
@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 13, 2017
@turboborsuk
Copy link
Author

turboborsuk commented Nov 13, 2017 •
edited

It's a completely different scenario than #1110.
It's an issue with checkmarks feedback on scrollbar, not actual code highlights.
You can try it with as little as 3 occurrences of a string in a file.

Please reopen and evaluate for duplicates more diligently.

FYI, it got broken only after 1.18.0

@alexdima
Copy link
Member

alexdima commented Nov 13, 2017 •
edited

@turboborsuk I cannot reproduce. I could not reproduce 2 hours ago, so I thought you just ran into #1110 (where online the first 1k selection highlights are painted in the overview ruler):

38088

Can you perhaps add more precise information to help me reproduce ?

@alexdima alexdima reopened this Nov 13, 2017
@alexdima alexdima added info-needed Issue requires more information from poster and removed *duplicate Issue identified as a duplicate of another issue(s) labels Nov 13, 2017
@turboborsuk
Copy link
Author

You can see this behavior below - when highlighting the first occurrence of the word "two" and hitting CTRL+F2 you get two checkmarks on the scrollbar. When doing the same after selecting the second one you get only one checkmark but the first occurrence is also highlighted for editing.

It can get annoying if you use the scrollbar feedback to know what parts of the file will be edited.

test

@alexdima
Copy link
Member

@turboborsuk thank you. I can reproduce now.

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Nov 13, 2017
@alexdima alexdima added this to the November 2017 milestone Nov 13, 2017
@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
3 participants
@alexdima @mjbvz @turboborsuk