Selection Highlight stops after 1000 matches

[latkin]

I don't see any setting to control this, so the behavior seems unexpected/unintuitive.

• Create text file with the line oh hai > 1000 times

Scenario 1

• Single-click hai on line 1

Expected: All instances of hai are highlighted
Actual: Only the first 500 are highlighted (markers on scrollbar indicate similar)

Scenario 2

• Double-click hai on line 1

Expected: All instances of hai are highlighted
Actual: First 500 instances are bright-highlighted, the next 500 are dim-highlighted, and the rest are un-highlighted.

Version 0.10.3
Commit 783ecf841a2b21edca6d86853670cae89b4c244f
Date 2015-11-26T14:06:31.538Z
Shell 0.34.1
Renderer 45.0.2454.85
Node 4.1.1

[alexdima]

This is intentionally capped at 1000 to prevent slowness / lagging.

[yisibl]

@alexandrudima There is no better way to solve it?

[alexdima]

Sure there is, currently the decorations are implemented to take quite a lot of memory, plus the painting code has at least one O(N) where N is the number of lines instead of O(viewport). Especially in this case where they are computed on each keystroke, the decorations don't need to be tracked.