Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Start without debugging" throws an error #38466

Closed
peppy opened this issue Nov 16, 2017 · 8 comments
Closed

"Start without debugging" throws an error #38466

peppy opened this issue Nov 16, 2017 · 8 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
November 2017

Comments

@peppy
Copy link

peppy commented Nov 16, 2017

  • VSCode Version: Code - Insiders 1.19.0-insider (3a7d517, 2017-11-15T06:11:00.322Z)
  • OS Version: Darwin x64 17.0.0
  • Extensions:
Extension Author (truncated) Version
vscode-markdownlint Dav 0.11.1
EditorConfig Edi 0.11.1
code-settings-sync Sha 2.8.5
gitlens eam 6.1.0
file-icons fil 1.0.7
csharpextensions jch 1.3.0
vscode-nuget-package-manager jmr 1.1.4
docomment k-- 0.0.17
csharp ms- 1.13.1
mono-debug ms- 0.15.8
snippet-creator nik 0.0.4
subtle-brackets raf 2.0.2
spellchecker swy 1.2.13
ayu tea 0.10.0

(1 theme extensions excluded)

Steps to Reproduce:

  1. Debug > Start Without Debugging
  2. Error is thrown
Cannot add property noDebug, object is not extensible: TypeError: Cannot add property noDebug, object is not extensible
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3781:817
    at n.Class.derive._oncancel.then (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:141:984)
    at file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3781:37
    at Object.g [as _notify] (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:135:449)
    at Object.enter (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:138:778)
    at n.Class.derive._oncancel._run (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:140:573)
    at n.Class.derive._oncancel._completed (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:140:14)
    at l (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:143:460)
    at n.Class.derive.join.r.forEach.j.then.o.(anonymous function) (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:143:674)
    at Object.g [as _notify] (file:///Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:135:449)

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the insiders label Nov 16, 2017
@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 16, 2017
@weinand
Copy link
Contributor

weinand commented Nov 16, 2017 •
edited

@isidorn the problem is independent from any debug extension and occurs because the launch configuration is now frozen, so it is no longer possible to add properties on the fly.

I could easily reproduce with node debugging.

This might affect other properties as well (e.g. the non-public properties starting with "__").

@weinand weinand assigned isidorn and unassigned weinand Nov 16, 2017
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Nov 16, 2017
@weinand weinand added this to the November 2017 milestone Nov 16, 2017
@isidorn
Copy link
Contributor

isidorn commented Nov 16, 2017

@weinand what do you mean by frozen? What changed in this area recently?

@weinand
Copy link
Contributor

weinand commented Nov 16, 2017 •
edited

@jrieken or @sandy081 mentioned that in the standup

@jrieken
Copy link
Member

jrieken commented Nov 16, 2017 •
edited

@weinand is correct. For performance reasons the configuration service doesn't clone configuration objects anymore (before handing them out to consumers). Instead config-objects are frozen and need to be cloned (which is expensive btw) manually if manipulation is desired.

@isidorn
Copy link
Contributor

isidorn commented Nov 16, 2017

@jrieken thanks for clarification.

@sandy081
Copy link
Member

Right, configuration object is frozen now for performance reasons.

I made a complete pass of usages of configuration object to check if cloning has to be done on the consumer side. One more miss here unfortunately.

@isidorn
Copy link
Contributor

isidorn commented Nov 16, 2017

@sandy081 no worries, I shuold have paid more attention in the standup yesterday 😊
I will fix it now

@peppy
Copy link
Author

peppy commented Nov 16, 2017

Thanks for the quick fix!

@roblourens roblourens added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
6 participants
@peppy @roblourens @jrieken @weinand @isidorn @sandy081