Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resizing of open editors pane #39734

Merged
merged 1 commit into from Dec 12, 2017
Merged

Conversation

ironyman
Copy link
Contributor

@ironyman ironyman commented Dec 5, 2017

Addresses these two issues

#17511
#491

@isidorn comments?

@msftclas
Copy link

msftclas commented Dec 5, 2017

CLA assistant check
All CLA requirements met.

@isidorn isidorn self-assigned this Dec 6, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 6, 2017

Currently we are in the release week which means I will only find time to review this next week.

@isidorn isidorn added this to the December 2017 milestone Dec 6, 2017
@ironyman
Copy link
Contributor Author

ironyman commented Dec 6, 2017

Thank you.

@isidorn
Copy link
Contributor

isidorn commented Dec 12, 2017

@ironyman good job. I like how you implemented this and how it behaves -> merging
I will only extract the elementCount into a local getter to not have code duplication.

🍻

@isidorn isidorn merged commit 441ad1e into microsoft:master Dec 12, 2017
isidorn added a commit that referenced this pull request Dec 12, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants