Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function calls not highlighted in JS #403

Merged
merged 1 commit into from
Nov 23, 2015
Merged

Conversation

Jakeii
Copy link
Contributor

@Jakeii Jakeii commented Nov 21, 2015

tmTheme files use meta.function-call to highlight function calls.

tmTheme files use `meta.function-call` to highlight function calls.
@msftclas
Copy link

Hi @Jakeii, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@aeschli
Copy link
Contributor

aeschli commented Nov 21, 2015

@Jakeii The JS text mate tokenizer is equal to https://raw.githubusercontent.com/textmate/javascript.tmbundle/master/Syntaxes/JavaScript.plist.
We'd rather not have our own variant. Maybe you want to make a pull request to that repo as well?
Once that repo is updated I'm happy to take the pull request.

@Jakeii
Copy link
Contributor Author

Jakeii commented Nov 21, 2015

@aeschli Interesting! Just installed textmate to be sure, and yes it does affect textmate itself. I'll update here when something happens over there.
textmate/javascript.tmbundle#44

aeschli added a commit that referenced this pull request Nov 23, 2015
Function calls not highlighted in JS
@aeschli aeschli merged commit 956a8f0 into microsoft:master Nov 23, 2015
@aeschli
Copy link
Contributor

aeschli commented Nov 23, 2015

textmate/javascript.tmbundle#44 got accepted, so merging in the change as well.
Thanks a lot, @Jakeii !

@Jakeii Jakeii deleted the patch-1 branch December 29, 2015 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants