Fix backspace in IME composition on iOS Safari #40546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rebornix Can you please verify this one. I am afraid to change my phone to Chinese because I will not be able to go back :-). |
|
@Yukaii thanks for your contribution! I'm not 100% confident about bubbling up the backspace event always when I'll do a full round of IME test before I merge https://github.com/Microsoft/vscode/wiki/IME-Test , if you are interested you can help with that as well. |
|
@rebornix Thanks for looking into this. I can help with macOS IME test. I use macOS Sierra. |
|
@Yukaii I think the code works fine, thanks for your help on this! |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix microsoft/monaco-editor#529
Current Behavior
Hitting backspace deletes text.
After
IME handles correctly.