Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable Touch Bar controls and leave control strip (#38333) #40692

Merged
merged 4 commits into from Dec 22, 2017
Merged

Option to disable Touch Bar controls and leave control strip (#38333) #40692

merged 4 commits into from Dec 22, 2017

Conversation

Baltazore
Copy link
Contributor

An attempt to add config option to disable rendering Touch Bar buttons at all issue #38333
This is my first PR to vscode repo.

@msftclas
Copy link

msftclas commented Dec 22, 2017

CLA assistant check
All CLA requirements met.

@bpasero
Copy link
Member

bpasero commented Dec 22, 2017

@Baltazore you should maybe coordinate with @viztor from #40400

Also see my #40400 (review) which applies here as well.

@bpasero bpasero self-assigned this Dec 22, 2017
@bpasero bpasero added this to the On Deck milestone Dec 22, 2017
@bpasero bpasero changed the title ISSUE #38333 Option to disable Touch Bar controls and leave control strip Option to disable Touch Bar controls and leave control strip (#38333) Dec 22, 2017
@bpasero bpasero modified the milestones: On Deck, December 2017/January 2018 Dec 22, 2017
@Baltazore
Copy link
Contributor Author

@bpasero thanks for review. I've changed my implementation according your review from #40400.
Sorry I didn't find #40400 earlier...

@bpasero
Copy link
Member

bpasero commented Dec 22, 2017

@Baltazore thanks, now you seem to have duplicate settings defined both on window and on keyboard? Can you remove the one on window?

@bpasero bpasero merged commit 4ceb6f9 into microsoft:master Dec 22, 2017
@bpasero
Copy link
Member

bpasero commented Dec 22, 2017

Thanks 👍

@Baltazore
Copy link
Contributor Author

Great 👍 Thank you! 🙏

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants