Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide proper display name, description and icon for out of the box extensions #43978

Closed
58 of 61 tasks
sandy081 opened this issue Feb 19, 2018 · 11 comments
Closed
58 of 61 tasks

Provide proper display name, description and icon for out of the box extensions #43978

sandy081 opened this issue Feb 19, 2018 · 11 comments
Assignees
@egamma @dbaeumer @aeschli @sandy081 @mjbvz @ramya-rao-a
Labels
extensions Issues concerning extensions
Milestone
February 2018

Comments

@sandy081
Copy link
Member

sandy081 commented Feb 19, 2018 •
edited by roblourens

With #17068, Built-in extensions will be shown in the extension viewlet. This needs adopting all extensions to provide proper name, description, read me and an icon (if no icon is provided it, defaults to VS Code icon) so that user will know about what each extension is for.

I am assigning users based on the last change done to the extension. If you are not the owner, please assign it to actual owner, otherwise me. Also please check it off, if the current details are good enough

NOTE: Make sure display name and descriptions are translated using nls
@sandy081 sandy081 added this to the February 2018 milestone Feb 19, 2018
@sandy081 sandy081 added the extensions Issues concerning extensions label Feb 19, 2018
sandy081 added a commit that referenced this issue Feb 19, 2018
@sandy081
#43978 Add more details to theme extensions
eed7399
sandy081 added a commit that referenced this issue Feb 19, 2018
@sandy081
#43978 Add details to editing extensions
eb789c5
sandy081 added a commit that referenced this issue Feb 19, 2018
@sandy081
#43978 Use nls
d321ced
sandy081 added a commit that referenced this issue Feb 19, 2018
@sandy081
#43978 add details
940f389
aeschli added a commit that referenced this issue Feb 20, 2018
@aeschli
description & name for built-in languages (#43978)
e45d279
@joaomoreno joaomoreno removed their assignment Feb 20, 2018
joaomoreno added a commit that referenced this issue Feb 20, 2018
@joaomoreno
consolidate git extensions
a563e2c 
related to #43978
joaomoreno added a commit that referenced this issue Feb 20, 2018
@joaomoreno
git extension icon
86e3c7e 
related to #43978
@sandy081
Copy link
Member Author

Also please make sure that Read me is updated.

@aeschli
Copy link
Contributor

aeschli commented Feb 21, 2018

@sandy081 Do we have a common template for the readme? Or maybe have it generated from the description?
IMO it would be good to mention that the extension is a built-in extension, cannot be uninstalled but disabled.

egamma added a commit that referenced this issue Feb 21, 2018
@egamma
Fixing #43978 add description/readme
eaec7c3
@egamma
Copy link
Member

egamma commented Feb 21, 2018 •
edited

Now that @joaomoreno has started it with the git extension I suggest that we add icons for all the bundled extensions as well.

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Feb 21, 2018 •
edited

Any guidelines on where we should (or shoudlnt) we get the icons from?

mjbvz added a commit that referenced this issue Feb 22, 2018
@mjbvz
Provide real name and description for markdown extension
ed8aa77 
#43978
mjbvz added a commit that referenced this issue Feb 22, 2018
@mjbvz
Add real displayname and description to the javascript extension
5a73518 
Part of #43978
mjbvz added a commit that referenced this issue Feb 22, 2018
@mjbvz
Add real displayName and descriptions to the typescript extension
3006e25 
Part of #43978
chrmarti added a commit that referenced this issue Feb 26, 2018
@chrmarti
Name, description, icon for merge-conflict extension (#43978)
264d0c2
@chrmarti chrmarti removed their assignment Feb 26, 2018
sandy081 added a commit that referenced this issue Feb 26, 2018
@sandy081
#43978 Generate read me from extension name and description
34a7352
@sandy081
Copy link
Member Author

Read me will be auto generated from extension manifest details if not provided

image

@sandy081 sandy081 mentioned this issue Feb 27, 2018
Closed
@sandy081
Copy link
Member Author

@aeschli, @ramya-rao-a, @joaomoreno, @dbaeumer, @mjbvz, @chrmarti, @egamma, @roblourens

Looks like most of the extensions versions are at 0.1. Can you please check your extensions versions and bump them at least to 1.0

@joaomoreno
Copy link
Member

Done!

@chrmarti chrmarti self-assigned this Feb 27, 2018
aeschli added a commit that referenced this issue Feb 27, 2018
@aeschli
built-in extensions: version to 1.0.0 (for #43978)
8bd41ce
@aeschli
Copy link
Contributor

aeschli commented Feb 27, 2018

Done!

aeschli added a commit that referenced this issue Feb 27, 2018
@aeschli
built-in extensions: version to 1.0.0 (for #43978)
8d0f22f
chrmarti added a commit that referenced this issue Feb 27, 2018
@chrmarti
Bump version (#43978)
a83ea2b
@chrmarti chrmarti removed their assignment Feb 27, 2018
ramya-rao-a added a commit that referenced this issue Feb 28, 2018
@ramya-rao-a
Update displayName, description for Emmet #43978
dcbeb21
@ramya-rao-a
Copy link
Contributor

Done for Emmet. The only remaining thing for Emmet is the icon for which I have contacted the Emmet library owner. Should be able to get something in a day or 2

ramya-rao-a added a commit that referenced this issue Feb 28, 2018
@ramya-rao-a
Version 1.0 for builtin extensions #43978 #44626
1f7b495
ramya-rao-a added a commit that referenced this issue Feb 28, 2018
@ramya-rao-a
Update displayName, description for Go extension #43978 #44626
4996cfb
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Feb 28, 2018 •
edited

@sandy081 I've updated all extensions such that

  • the least version is 1.0.0
  • the Display Name for language related extensions are appropriately Basics/Features
  • removed "and other language features" from the description for all Language Basics extensions. That will just mislead users to expect more from the extension
  • All the themes get the same icon

The only thing left is to get icons for

  • Emmet
  • Typescript
  • Html
  • Css
  • Json
  • Markdown
  • Php

which is tracked in #44626.

We can close this issue

@sandy081
Copy link
Member Author

Thanks @ramya-rao-a

Closing this

chrmarti added a commit that referenced this issue Mar 2, 2018
@chrmarti
Add link to documentation (#43978)
ab7f6e8
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@egamma egamma

@dbaeumer dbaeumer

@aeschli aeschli

@sandy081 sandy081

@mjbvz mjbvz

@ramya-rao-a ramya-rao-a

Labels
extensions Issues concerning extensions
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
8 participants
@joaomoreno @egamma @dbaeumer @aeschli @chrmarti @sandy081 @mjbvz @ramya-rao-a