Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling built in extensions #17068

Closed
dbaeumer opened this issue Dec 12, 2016 · 58 comments
Closed

Allow disabling built in extensions #17068

dbaeumer opened this issue Dec 12, 2016 · 58 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality on-testplan
Milestone

Comments

@dbaeumer
Copy link
Member

  • VSCode Version: 1.8.0-insider

We have requests to support disabling all TS functionality. Instead of introducing a setting we should allow disabling built in extensions.

@waderyan
Copy link

@dbaeumer so I understand, would the user do something like this:

// in settings
"useBuiltInExtensions": // set to false

or would there be a setting for each built in extension?

// in settings
"useBuiltIn.TypeScriptExtension": // set to false

A concern I have is that the flow of this is so different than our other extensions. Should we consider an approach Atom took and show built in extensions in the extension viewlet? Maybe this is the approach you are suggesting.

@mjbvz mjbvz changed the title Allow disabling build in extensions Allow disabling built in extensions Dec 12, 2016
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 12, 2016

@waderyan Would another approach be to have at least some of the built-in extensions listed in the extension pane where they could be managed using the standard extension UI?

@waderyan
Copy link

@mjbvz I agree with your point. What you describe is what I intended to describe in this sentence:

Should we consider an approach Atom took and show built in extensions in the extension viewlet?

Comment communication failure 😄

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 12, 2016

@waderyan Ok, sorry I missed that. That makes the most sense to me as well. We probably don't want all of the built-in extensions listed there, but it does make sense to whitelist extensions like typescript to address specific problems

@dbaeumer
Copy link
Member Author

@waderyan @mjbvz I discussed that with @sandy081 and the idea was to have them listed in the extension vielwet and to allow disabling them but not to uninstall to give users a consistent experience.

@ubershmekel
Copy link

ubershmekel commented Jan 16, 2017

For anyone else finding this thread - my current solution to disable the internal typescript is to rename tsconfig.json to tsconfig2.json, then you let npm run typsecript like so:

  "scripts": {
    "tsc": "tsc --p tsconfig2.json",

For maintainers pondering why, here's my setup

topRepoFolderOpenInVSCode/
    otherFolders/
    nodeAppFolder/
        package.json
        tsconfig.json
        src/
            myfile.ts

I wanted to install typescript only locally (not -g, so I can just npm install and be done) so I have an npm script that runs tsc. The problem is VSCode does not let you click through to typescript errors because the error output references src/myfile.ts and not nodeAppFolder/src/myfile.ts. So my tasks.json can't just use cwd to work from nodeAppFolder, instead I use npm's --prefix to run the npm script that runs tsc. The problem is that the secret internal typescript isn't following my special setup and is evaluating based on the not-root tsconfig.json creating duplicate errors which I cannot cannot click through. They even sometimes come back after they'd already been fixed, it must be confused somehow. So I'm using my own secret tsconfig2.json.

Edit - I'm still seeing phantom errors. Going to open a separate issue. Sorry to bother.

@Kureev
Copy link

Kureev commented Apr 12, 2017

Hi there! Any updates on this thread? Can community help you with this issue?

@benasvip
Copy link
Contributor

I'm also wondering if there's any updates on this thread. 😛

@DrStrangepork
Copy link

Also looking for update. The default Language Mode menu (#18224) is way too long , I'd like to disable languages that I never use.

@fimius23
Copy link

fimius23 commented May 2, 2017

+1

@mehas
Copy link

mehas commented May 2, 2017

As a short term solution for the Language Mode menu being too long, navigating to /resources/app/extensions/ within the application folder and renaming each extension's package.json (to something like package.json.bak) will prevent them from appearing in the menu. (The changes will be reset when updating VS Code).

@CBuntrock
Copy link

Great to see discussion about this. It would be nice to have more control over VS Code by disabling that "magic like intellisense" service running in background. That is helpful to understand what is supporting and doing analysis.

@Kureev
Copy link

Kureev commented May 5, 2017

Just updated my VSCode and it seems there are no more ts checks by default.

Thank you so much, guys ❤️! Great job! 🙌 !

@benasvip
Copy link
Contributor

benasvip commented May 5, 2017

@Kureev Maybe this is bug 😄
@mjbvz This is true? There are no more ts checks by default? Can you provide us more info, thanks!

@Kureev
Copy link

Kureev commented May 5, 2017

@svipben it's in the changelog (1.12.1) 😉

@benasvip
Copy link
Contributor

benasvip commented May 5, 2017

@Kureev Thanks!

@iammerrick
Copy link

Pa pa pa please throw us Flow kids a bone?

@mattacosta
Copy link
Contributor

Don't forget to deprecate/remove the php.suggest.basic setting as well. It was put in as a workaround for this a long time ago.

@FezVrasta
Copy link

FezVrasta commented Feb 14, 2018

Hey @zoontek I'm trying to build on Mac but I get

$ node-gyp configure
gyp: binding.gyp not found (cwd: /Users/fezvrasta/Projects/vscode) while trying to load binding.gyp

I have all the requirements installed and XCode works properly, ideas?

@drwlrsn
Copy link

drwlrsn commented Feb 14, 2018

@FezVrasta Although this isn't really the place for this, ignore the build instructions in the comment above; just use the build from source instructions in the wiki. Once that works you can make the edits as suggested above.

@shaun-sweet
Copy link

This issue pushed me back to atom. Nuclide has come a long way since the last time I’ve used it. Performance is speedy now too

@sandy081
Copy link
Member

Disabling built-in extensions support is there now in insiders today. Please try it out.

kapture 2018-02-20 at 10 46 32

@iammerrick
Copy link

@sandy081 This is working so well so far! Thank you so much!

@nickshevr
Copy link

nickshevr commented Mar 5, 2018

@sandy081 I don't have this option on my mac'os, I checked for updates and there is nothing, whats wrong?

@iammerrick
Copy link

@nickshevr Insiders build my friend. :-)

@nickshevr
Copy link

nickshevr commented Mar 5, 2018

@iammerrick is it private build or I can get it?


UPD: ok, I found It #43361
Hope It will release soon.

@iammerrick
Copy link

@nickshevr Free for all amigo https://code.visualstudio.com/insiders/

@nickshevr
Copy link

@iammerrick thanks a lot. Today is just my second day with VS Code after 2 years with WS, and you know, I almost like it.

@nickshevr
Copy link

@iammerrick I'm sorry for mention you agian, but I couldn't fix my issue. Is there any way to turn off TS checks but still use JS checks?

I want to fix this:
image
But I dont want to turn off this:
image

@iammerrick
Copy link

  "javascript.validate.enable": false,
  "javascript.format.enable": false,

In your settings...

@nickshevr
Copy link

nickshevr commented Mar 5, 2018

I tested it before Insiders build, don't like this way. As I said

I wanna still use JS checks (without ts features)

This method turns off all useful typed suggestions.

NP, I'll try another ways.

@dsifford
Copy link

dsifford commented Mar 7, 2018

@sandy081 This is great! Thanks so much.

I'm curious if there are any plans to add the ability to disable builtins from the command line?

I have a small script that I use to synchronize my installed extensions between machines that leverages the --list-extensions, --install-extension, and --uninstall-extension APIs and it would be awesome to be able to --disable-extension (with expanded support to @builtins) to synchronize the state of my disabled extensions.

Thanks again.

@tafelito
Copy link

tafelito commented Mar 8, 2018

Hi, I just installed the new vscode version 1.21.0 that allows you to disable builtin extensions. I disabled the TypeScript extension but I'm still having issues with the intellisense when using flow.

If I open a file from the explorer, and then from a different file I do "Go to definition" to the same file, that files opens twice.

image

image

image

If I remove // @flow then it doesn't do anything when trying to go to definition

Do I have to add any extra config?

Thanks

@sandy081
Copy link
Member

@dsifford Please open a feature request for your requirement

@tafelito Please open a new issue explaining the bug you are facing.

Thanks

@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests