Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename built-in JavaScript extension? #44166

Closed
mjbvz opened this issue Feb 22, 2018 · 9 comments
Closed

Rename built-in JavaScript extension? #44166

mjbvz opened this issue Feb 22, 2018 · 9 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 22, 2018

Bug
With #17068, the organization of our built-in extensions will now be exposed to users. The JavaScript extension's name is a confusing as this extension does not provide most of our javascript language support (it instead comes from the TypeScript extension)

Proposal

  • Move all JavaScript language and grammar code into the TypeScript extension, leaving just the package.json logic in the existing javaScript extension.

  • Rename the remaining JavaScript extension to packageJson extension.

Any thoughts @dbaeumer?

@dbaeumer
Copy link
Member

We had a discussion here today and to make things consistent with other languages we should have IMO two extensions:

  • one that only contributes the grammars and snippets for both JS and TS
  • one that brings the language smartness

This is for example what happens with all the other languages like C#, C++ where we only ship the grammar and the smartness comes with a second plugin.

However I have no idea how to name them. CCing @aeschli since we discussed the same JSON, CSS, ... yesterday.

@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 22, 2018

Ok, how about something like following then:

  • Rename typescript to TypeScript and JavaScript Language Features. Move syntax highlighting and snippets out of typescript to new language basics extension

  • Move js/ts syntax and snippets to a new TypeScript and JavaScript Language Basics extension (or create two new "language basics" extension, one for JS and one for TS)

  • Rename javascript to Package.json Support

@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 23, 2018

8e0bdd6 splits the package.json/bower specific logic out into a new package-json extension

@dbaeumer
Copy link
Member

I like the split and the more explicit naming.

@aeschli
Copy link
Contributor

aeschli commented Feb 23, 2018

@mjbvz Instead of a new package-json extension, lets use the npm extension

@mjbvz mjbvz added this to the February 2018 milestone Feb 23, 2018
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Feb 23, 2018
@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 23, 2018

@aeschli Good idea. ac5ed16 makes that change

e23c58b Creates a new typescript-basics extension which just has typescript syntax. I'll change the display name for the existing typescript extension to make it more clear that it is contributing intellisense

@mjbvz mjbvz closed this as completed Feb 23, 2018
@aeschli
Copy link
Contributor

aeschli commented Feb 26, 2018

@mjbvz Thinking about this more, I think it would cleaner use the id vscode.typescript for the basic language extensions, and use something like vscode.typescript-language-service (or maybe vscode.typescript-language-support) or for the rich language extension.
vscode.typescript is what other extensions already use when they depend on the typescript language definition, and what they should continue to depend on, unless they extend the language service.
Also that way we stay consistent with the other language extension names.
I'll have to do the same for css and html.

@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 27, 2018

@ramya-rao-a Will changing the built-in extension identifiers mess up telemetry?

@ramya-rao-a
Copy link
Contributor

@mjbvz It's a mess that we can sort out. Folks looking at raw events will have to look for both old and new names. Our cooking jobs can be updated to consolidate both.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

4 participants