Keeping find input value unchanged on replace if find input is active, fixes #41027 #44984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rebornix
force-pushed
the
replace-regex-fix
branch
from
6a5d90b
to
3fb52f9
Compare
|
@liqwid thanks for your help, it looks great! |
|
Awesome! thanks for merging, regexes rule 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when replace action occurs editor text selection replaces find input. That causes problems because regexes get replaced "tes." => "test".
This pull request prevent replacing find input value by editor text selection on replace action when find input is active.