Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code.ps1 for Windows PowerShell #45274

Closed
wants to merge 1 commit into from
Closed

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Mar 8, 2018

This will fix #38587.

However, you have to change the execution policy to other than Restricted after installing VSCode by the following commandlet for example (this requires the administrator's privilege):

Set-ExecutionPolicy RemoteSigned -Scope CurrentUser

I know this process must corrupt users who run VSCode in Windows 10, use PowerShell as the default shell, which is opened from the context menu that appears after you right-click the start button or press Win + X, and are not used to the shell so much.

This PR doesn't concern users who use Windows 8.1 or earlier (because most of they use only CMD instead) and another OS than Windows.

- Make it possible to open directories in UNC paths
- Fixes microsoft#38587
@msftclas
Copy link

msftclas commented Mar 8, 2018

CLA assistant check
All CLA requirements met.

@joaomoreno
Copy link
Member

Is there maybe another way to do this? I really don't like changing execution policies for everybody.

@joaomoreno joaomoreno added this to the Backlog milestone Mar 12, 2018
@joaomoreno joaomoreno added under-discussion Issue is under discussion for relevance, priority, approach workbench-os-integration Native OS integration issues labels Mar 12, 2018
@tats-u
Copy link
Contributor Author

tats-u commented Mar 12, 2018

I don't know how to deal with this issue only with CMD. I think it's too legacy and must be replaced with something better like PowerShell, but PowerShell is too strict to be adopted because of, for example, the execution policy. I wish it was so permissive that everyone could run shell scripts casually like those of CMD and Bash.

@tats-u
Copy link
Contributor Author

tats-u commented Mar 12, 2018

I don't mind suspending this PR because I think it should be discussed by more people.

@joaomoreno
Copy link
Member

Yup, I'll have to close it in its current form. Thanks for the effort tho!

@joaomoreno joaomoreno closed this Mar 14, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
under-discussion Issue is under discussion for relevance, priority, approach workbench-os-integration Native OS integration issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot open directories in UNC paths by the command code
3 participants