-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTML highlighting & IntelliSense #461
Conversation
* acronym * big * strike * tt * frame * frameset * noframes
* bdo * data * embed * main * rb, rp, rt, rtc, ruby * s * source * template * track * u * wbr
* svg * menuitem (already in IntelliSense)
The element is no longer part of the API. It is no fully JavaScript based.
The prefixless version should always be last, so that the older prefixed implementation (if different) doesn’t win out in the cascade. Especially now other browsers (Edge) support the webkit version as well. Removed -o- as that was only used by Opera 11.5, which hasn’t been the current version since I worked there. Presto users were quickly auto-updated to Opera 12, and now Opera uses Blink.
Hi @dstorey, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
…the HTML elements in CSS IntelliSense should now be consistent with what is syntax highlighted via the TextMate file. There are things that could arguably be removed, like that was dropped from the WhatWG spec (and Edge will not implement, and Chrome want to deprecate) and , which was dropped from the W3C version of the spec.The HTML IntelliSense also needs double checked. I added the element as that was bugging me, but as it is not in alphabetical order, it will take a while to cross check against the 2 other HTML lists and the spec. It would be nice eventually to only have one list of elements rather than 3 that need to be kept in sync. |
It is not included in the list of global attributes for either W3C HTML5/5.1 or WhatWG Living Standard. There was a proposal for an inert keyword but it was dropped whatwg/html@5ddfc78 f1e4ad
Add download attribute (now widely supported.) Remove media attribute (only valid on style and link elements)
* Add onlanguagechange * Remove onblur, onerous, onfocus, onload (existing global attributes) * Move onresize and onscroll to global event handlers
option is a child of datalist, not an attribute
* Add allowfullscreen attribute * Set sandbox to boolean attribute * Add valid values for the sandbox attribute
* Add minlength attribute * Update required attribute to a boolean attribute
…as used by CSP. Included in W3C HTML5.1 and WHATWG Living standard. Also re-ordered <script> to match spec, to make it easier to scan for updates.
…no longer valid in HTML5.1 and WhatWG HTML
…as used by Web Components.
* Add menuitem element and define valid values for menuitem type attribute * Add valid values for menu type attribute * Add menu to valid button values * Remove old command element
…auto isn’t valid when using on <bdo> element, so need to find how to show that. It is valid for the global dir attribute.
…auto isn’t a valid value for draggable. true/false/auto isn’t needed once that uses a boolean.
…and capitalise GET / POST. Old get/post set is still needed for formmethod on input and button.
Decided to update the HTML auto-complete/IntelliSense file while I was at it. It should be now in sync with the CSS auto-complete for HTML elements, and have all the correct attributes per the latest HTML5.1 spec and WHATWG Living standard, along with the valid enum and boolean values for those |
Update HTML highlighting & IntelliSense
@dstorey Really nice, thanks so much. One thing: |
You mentioned the 3 files we have to keep in sync. |
@aeschli sure, I can look at making a PR to TextMate. I did a similar update to Atom when it was new, which I guess wasn't pushed back to TextMate as this version was further out of date than that version. I guess there are a fair few of these files of different vintages across the different editors that use TextMate plists. |
@dstorey Lets submit the pull request and see if they take it. The experiences so far have been good, with a quick turnaround. Our goal is to avoid a branch as long as we can, so either side can profit from bug fixes. |
The "control socket" is now hardcoded and virtual: any 'connections' that come in are not forwarded on the network, but served by the control server directly. This was just a small change since the raw channel connections have `into_split() -> (AsyncRead, AsyncWrite)`. What a coincidence! I realized that our graceful restarts don't really work well in the new world. I kept them somewhat graceful by just "queuing" the update to happen after the requesting socket disconnects. Similar to VS Code itself. I also realized our detection for ports/URLs in `serve-local` was wonky, so I fixed that (not sure anyone is using it). Fixes #461 Fixes #434
HTML syntax highlighting and IntelliSense in CSS were out of sync and somewhat outdated.
Removed deprecated:
Added from HTML5:
Added from HTML5.1 (less stable spec but many have 1 or 2 implementations)
Also updated the CSS transition snippet, which uses the wrong order and has -o- prefix that has not been needed for a long time.