Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'dispose' of undefined (fixes #4573) #4614

Merged
merged 1 commit into from
Mar 23, 2016
Merged

Cannot read property 'dispose' of undefined (fixes #4573) #4614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 14 additions & 14 deletions src/vs/base/parts/quickopen/browser/quickOpenModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,21 +650,21 @@ class Renderer implements IRenderer<QuickOpenEntry> {
public disposeTemplate(templateId: string, templateData: any): void {
if (templateId === templateEntryItem) {
this.entryItemRenderer.disposeTemplate(null, templateId, templateData);
} else {
const data = templateData as IQuickOpenEntryGroupTemplateData;
data.actionBar.dispose();
data.actionBar = null;
data.container = null;
data.description.dispose();
data.description = null;
data.detail.dispose();
data.detail = null;
data.group = null;
data.icon = null;
data.label.dispose();
data.label = null;
data.prefix = null;
}

const data = templateData as IQuickOpenEntryGroupTemplateData;
data.actionBar.dispose();
data.actionBar = null;
data.container = null;
data.description.dispose();
data.description = null;
data.detail.dispose();
data.detail = null;
data.group = null;
data.icon = null;
data.label.dispose();
data.label = null;
data.prefix = null;
}
}

Expand Down