Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command navigation should respect current scrolling position #46729

Closed
kieferrm opened this issue Mar 27, 2018 · 2 comments
Closed

Command navigation should respect current scrolling position #46729

kieferrm opened this issue Mar 27, 2018 · 2 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone
October 2019

Comments

@kieferrm
Copy link
Member

Testing #46594.

  1. Manually scroll up, so that at least one command is scrolled off the bottom of your terminal
  2. Cmd+ArrowUp

-> The last command before the prompt is revealed, i.e. the terminal scrolls down. I'd expect it to scroll up. The reason here is a predictable workflow. I can use command navigation to reveal a command. Then I refocus on something else. Then I come back to the terminal and use Cmd+ArrowUp. Now, the terminal scroll up while when I scrolled manually before it doesn't. However, the time elapsed between those two steps can be substantial.
@kieferrm kieferrm added the terminal Integrated terminal issues label Mar 27, 2018
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug ux User experience issues labels Jun 22, 2018
@Tyriar Tyriar added this to the Backlog milestone Jun 22, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 17, 2018

We should do #46561 before tackling this one.

@Tyriar Tyriar added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Sep 17, 2018
@Tyriar Tyriar changed the title Command navigation does respect current scrolling position Command navigation should respect current scrolling position Sep 17, 2018
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue and removed feature-request Request for new features or functionality ux User experience issues labels Oct 8, 2019
@Tyriar Tyriar modified the milestones: Backlog, October 2019 Oct 8, 2019
@Tyriar Tyriar removed the polish Cleanup and polish issue label Oct 23, 2019
@Tyriar Tyriar closed this as completed in 215fa33 Oct 23, 2019
@Tyriar
Copy link
Member

Tyriar commented Oct 23, 2019

To verifier: Experiment with jumping around commands, scrolling and jumping around more. Note that the scroll position navigation only applies when you do not have an active selection from the select to commands (cmd+shift+up/down).

@JacksonKearl JacksonKearl added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@Tyriar @kieferrm @JacksonKearl