Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #33132: Regenerate php functions. #47865

Merged
merged 2 commits into from Apr 22, 2018
Merged

Fix #33132: Regenerate php functions. #47865

merged 2 commits into from Apr 22, 2018

Conversation

mattacosta
Copy link
Contributor

See #33132 (comment) for details.

@roblourens roblourens self-assigned this Apr 14, 2018
@roblourens roblourens added this to the April 2018 milestone Apr 14, 2018
@roblourens
Copy link
Member

Where is the manual.xml file? How can we update this again in the future?

@mattacosta
Copy link
Contributor Author

The best way to get the latest version is to just checkout a copy of the documentation:

svn co https://svn.php.net/repository/phpdoc/modules/doc-en doc-en

Then run doc-base/configure.php, which (by default) should give you a nice ~43MB file to play around with.

As for updating this again, that's a bit trickier since I didn't have whatever that php-exclude_generate_php_globals.js file was and had to edit a bit of code to get the proper format.

@roblourens
Copy link
Member

I see, I just don't follow how you actually generated the phpGlobalFunctions.ts this time. If you have a script that generates that file from the xml file, could we also check in that script?

@mattacosta
Copy link
Contributor Author

Yes, that is how I created it. I'll see about cleaning it up and eventually committing it somewhere too.

@roblourens roblourens merged commit b6a5170 into microsoft:master Apr 22, 2018
@roblourens roblourens added the php PHP support issues label Apr 22, 2018
@mattacosta mattacosta deleted the mattacosta/regenerate-php-globals branch April 23, 2018 00:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
php PHP support issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants