Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unescaped HTML character in id field not handled #48563

Closed
tsalinger opened this issue Apr 24, 2018 · 1 comment
Closed

Unescaped HTML character in id field not handled #48563

tsalinger opened this issue Apr 24, 2018 · 1 comment
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Milestone
April 2018

Comments

@tsalinger
Copy link
Contributor

testing #48407

 "viewsContainers": {
            "activitybar": [
                {
                    "id": "&",
                    "title": "SomeTitle",
                    "icon": "resources/test2.svg"
                }
            ]
        },

leads to

ERR Failed to execute 'insertRule' on 'CSSStyleSheet': Failed to parse the rule '.monaco-workbench > .activitybar .monaco-action-bar .action-label.extensionViewlet-&{-webkit-mask: url('C:/vscode_projects/testplanItemsApril/test-view-containers--48407/resources/test2.svg') no-repeat 50% 50%; -webkit-mask-size: 22px;}'.: Error: Failed to execute 'insertRule' on 'CSSStyleSheet': Failed to parse the rule '.monaco-workbench > .activitybar .monaco-action-bar .action-label.extensionViewlet-&{-webkit-mask: url('C:/vscode_projects/testplanItemsApril/test-view-containers--48407/resources/test2.svg') no-repeat 50% 50%; -webkit-mask-size: 22px;}'.
    at Object.t.createCSSRule (file:///C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:203:564)
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues labels Apr 24, 2018
@sandy081 sandy081 added this to the April 2018 milestone Apr 24, 2018
@sandy081
Copy link
Member

@tsalinger Good catch.

Allowed only alphanumeric letters, '_', '-' in Id.

@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 27, 2018
@RMacfarlane RMacfarlane mentioned this issue Apr 27, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@RMacfarlane @sandy081 @tsalinger