Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor "Find" panel keybinding is overridden #49231

Closed
atombender opened this issue May 4, 2018 · 5 comments
Closed

Editor "Find" panel keybinding is overridden #49231

atombender opened this issue May 4, 2018 · 5 comments
Assignees
@rebornix @isidorn
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
May 2018

Comments

@atombender
Copy link

  • VSCode Version: 1.23.0
  • OS Version: macOS 10.13.3

Steps to Reproduce:

  1. Hit Cmd + F to show the "Find" panel.
  2. Hit Cmd + Option + R to toggle the regex mode.
  3. This almost always opens Finder for the current directory. Sometimes it works correctly, but I haven't been able to determine what steps modify the behaviour.

This is me doing the above steps:

vsc

I also noticed that Cmd + Option + C, which should toggle case, does nothing. Cmd + Option + W, to toggle whole words, works.

My keybindings: https://gist.github.com/atombender/d61bb4d54d6abca9ebb2a1c9f25c58d0

Does this issue occur when all extensions are disabled?: Yes
@vscodebot vscodebot bot added the new release label May 4, 2018
@rebornix
Copy link
Member

rebornix commented May 4, 2018

Reveal File in OS checks if the editor is focused editorTextFocus, which is false when the find widget is focused. We need to check if editor internal widgets are focused or not.

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label May 4, 2018
@rebornix rebornix added this to the May 2018 milestone May 4, 2018
rebornix added a commit that referenced this issue May 4, 2018
@rebornix
re #49231.
cbd2e01
@atombender
Copy link
Author

Super, thanks!

@isidorn
Copy link
Contributor

isidorn commented May 7, 2018

@rebornix thanks for fixing this!

@atombender
Copy link
Author

@rebornix I think the same fix is needed for Cmd + Option + C.

@isidorn
Copy link
Contributor

isidorn commented May 8, 2018

@atombender that is already fixed here https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/electron-browser/fileCommands.ts#L436

@jrieken jrieken added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
4 participants
@atombender @rebornix @jrieken @isidorn