Editor "Find" panel keybinding is overridden

[atombender]

• VSCode Version: 1.23.0
• OS Version: macOS 10.13.3

Steps to Reproduce:

1. Hit Cmd + F to show the "Find" panel.
2. Hit Cmd + Option + R to toggle the regex mode.
3. This almost always opens Finder for the current directory. Sometimes it works correctly, but I haven't been able to determine what steps modify the behaviour.

This is me doing the above steps:

I also noticed that Cmd + Option + C, which should toggle case, does nothing. Cmd + Option + W, to toggle whole words, works.

My keybindings: https://gist.github.com/atombender/d61bb4d54d6abca9ebb2a1c9f25c58d0

Does this issue occur when all extensions are disabled?: Yes

[rebornix]

Reveal File in OS checks if the editor is focused editorTextFocus, which is false when the find widget is focused. We need to check if editor internal widgets are focused or not.

[atombender]

Super, thanks!

[isidorn]

@rebornix thanks for fixing this!

[atombender]

@rebornix I think the same fix is needed for Cmd + Option + C.

[isidorn]

@atombender that is already fixed here https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/electron-browser/fileCommands.ts#L436