Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltips to extension navbar #49825

Merged
merged 3 commits into from
May 16, 2018
Merged

Add tooltips to extension navbar #49825

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f0fea7
Add tooltips to extension navbar
InspectorDeno May 14, 2018
dbbdea8
Change tooltip captions
InspectorDeno May 16, 2018
ab27125
Remove check for existing tooltip
InspectorDeno May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,12 @@ class NavBar {
this.actionbar = new ActionBar(element, { animated: false });
}

push(id: string, label: string): void {
push(id: string, label: string, tooltip: string): void {
const run = () => this._update(id);
const action = new Action(id, label, null, true, run);

action.tooltip = tooltip;

this.actions.push(action);
this.actionbar.push(action);

Expand Down Expand Up @@ -371,10 +373,10 @@ export class ExtensionEditor extends BaseEditor {

this.navbar.clear();
this.navbar.onChange(this.onNavbarChange.bind(this, extension), this, this.transientDisposables);
this.navbar.push(NavbarSection.Readme, localize('details', "Details"));
this.navbar.push(NavbarSection.Contributions, localize('contributions', "Contributions"));
this.navbar.push(NavbarSection.Changelog, localize('changelog', "Changelog"));
this.navbar.push(NavbarSection.Dependencies, localize('dependencies', "Dependencies"));
this.navbar.push(NavbarSection.Readme, localize('details', "Details"), localize('detailstooltip', "Extension details, rendered from the extension's 'README.md' file"));
this.navbar.push(NavbarSection.Contributions, localize('contributions', "Contributions"), localize('contributionstooltip', "Extension contributions to the VS Code editor"));
this.navbar.push(NavbarSection.Changelog, localize('changelog', "Changelog"), localize('changelogtooltip', "Extension update history, rendered from the extension's 'CHANGELOG.md' file"));
this.navbar.push(NavbarSection.Dependencies, localize('dependencies', "Dependencies"), localize('dependenciestooltip', "Extension dependencies, lists other extensions this extension depends on"));

this.editorLoadComplete = true;
return super.setInput(input, options);
Expand Down