Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype update import paths on file rename/move for JS/TS #50074

Merged
merged 7 commits into from May 21, 2018

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented May 18, 2018

#19439

Adds a prototype that updates import paths when you rename or move a js/ts file. This is accomplished by introducing a new proposed VS Code API for understanding when a resource has been renamed or rename (we don't try detecting renames/moves that happen outside of vscode). The new proposed API is rough and needs more thought, see #43768

TODO:

  • Remove setTimeout and replace with proper handler for when TS opens file.
  • Add prompt to update paths on rename? Only should fire if there are changes
  • Add setting to always update paths on rename (if we add a prompt)

@mjbvz mjbvz added this to the May 2018 milestone May 18, 2018
@mjbvz mjbvz self-assigned this May 18, 2018
@mjbvz mjbvz requested review from jrieken and alexdima May 18, 2018 01:59
@mjbvz
Copy link
Contributor Author

mjbvz commented May 21, 2018

@jrieken and @alexandrudima I'm merging this prototype with the understanding that the proposed VS Code api component is not complete. I'd like to schedule getting a proper rename file handler API for next iteration

@mjbvz mjbvz merged commit ff5f422 into master May 21, 2018
@mjbvz mjbvz deleted the mjbvz/rename-file-update-paths-proto branch July 24, 2018 01:11
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant