Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Start debug with stop on entry" action #50610

Closed
wants to merge 2 commits into from
Closed

Add "Start debug with stop on entry" action #50610

wants to merge 2 commits into from

Conversation

Krzysztof-Cieslak
Copy link
Contributor

Fix #49855

CC: @isidorn

@isidorn
Copy link
Contributor

isidorn commented May 29, 2018

@Krzysztof-Cieslak thanks for this PR. However I am not yet convinvced we need this behavior, only 1 user asked for this and this feels like and IDE-ish feature.
Will not merge this in yet.

For future reference just becuase there is an open feature request does not mean we want to add it, otherwise vscode would soon be bloated.

@isidorn isidorn self-assigned this May 29, 2018
@isidorn isidorn added this to the Backlog milestone May 29, 2018
@Krzysztof-Cieslak
Copy link
Contributor Author

Krzysztof-Cieslak commented May 31, 2018

I think it's decent feature, and while I understand point about worrying about getting too bloated, I don't feel one additional action for debug (which has like 20 actions defined) is ground breaking ;-)

Also, issue got couple upvotes.

@isidorn
Copy link
Contributor

isidorn commented May 31, 2018

@Krzysztof-Cieslak thanks for feedback. Let's wait a bit and see in a couple of months about this. Thanks

@Krzysztof-Cieslak Krzysztof-Cieslak deleted the startDebugWithStopOnEntry branch May 9, 2019 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F10 and F11 should start debugging with stopAtEntry:true
2 participants