Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show progress indicator for views that take a long time to load #50730

Closed
mjbvz opened this issue May 29, 2018 · 4 comments
Closed

Show progress indicator for views that take a long time to load #50730

mjbvz opened this issue May 29, 2018 · 4 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Milestone
June 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented May 29, 2018

  • VSCode Version:
  • OS Version:

Steps to Reproduce:

  1. Clone https://github.com/Microsoft/vscode-extension-samples/tree/master/tree-view-sample
  2. Update getChildren to take a long time to complete using setTimeout or similar
  3. Start VS Code and switch to the view

Bug
No clear progress indicator showing that the view is being loaded. There is a progress indicator when the individual child elements are being expanded
@sandy081
Copy link
Member

Assigning to May for investigation.

@sandy081 sandy081 added the tree-views Extension tree view issues label May 30, 2018
@sandy081 sandy081 added this to the May 2018 milestone May 30, 2018
@sandy081
Copy link
Member

@mjbvz I see the progress always. May I know where you do not see it in particular?

kapture 2018-05-30 at 12 44 51

@sandy081 sandy081 added the info-needed Issue requires more information from poster label May 30, 2018
@sandy081 sandy081 removed this from the May 2018 milestone May 30, 2018
@mjbvz
Copy link
Contributor Author

mjbvz commented May 30, 2018 •
edited

In a contributed view container, such as the one from the tree view sample, I do not see a progress indicator when the views of the container are first loaded:

may-30-2018 10-27-54

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels May 31, 2018
@sandy081 sandy081 added this to the June 2018 milestone May 31, 2018
@sandy081
Copy link
Member

Right, progress is not shown for custom view containers. This needs to add support for custom locations in progress service.

sandy081 added a commit that referenced this issue Jun 11, 2018
@sandy081
#50730 Move progress service 2 to workbench
41729b4
@mjbvz mjbvz added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
2 participants
@sandy081 @mjbvz