Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the reasonText atriburte of the extension reccomendation in aria-label #51473

Merged
merged 2 commits into from
Jun 11, 2018
Merged

Use the reasonText atriburte of the extension reccomendation in aria-label #51473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85224e0
Use the `reasonText` atriburte of the extension reccomendation in label
Jun 8, 2018
a95b046
Lower case extension id before lookup
Jun 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/parts/extensions/browser/extensionsList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export class Renderer implements IPagedRenderer<IExtension, ITemplateData> {

const extRecommendations = this.extensionTipsService.getAllRecommendationsWithReason();
if (extRecommendations[extension.id.toLowerCase()]) {
data.root.setAttribute('aria-label', extension.displayName + '. ' + extRecommendations[extension.id]);
data.root.setAttribute('aria-label', extension.displayName + '. ' + extRecommendations[extension.id.toLowerCase()].reasonText);
addClass(data.root, 'recommended');
data.root.title = extRecommendations[extension.id.toLowerCase()].reasonText;
}
Expand Down