Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statusbar polishing #52149

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Statusbar polishing #52149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/vs/workbench/browser/parts/statusbar/media/statusbarpart.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

.monaco-workbench > .part.statusbar {
box-sizing: border-box;
cursor: default;
Copy link
Member

@bpasero bpasero Jun 18, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeonardoBraga can we just fix it for this particular issue as outlined in #51515 and apply a cursor:default style for the progress message here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely. My reasoning behind setting the default cursor style instead of specializing it for each status bar part is that - unless required otherwise - all items in the status bar should not have a "selectable" cursor or a "clickable" one. If you don't agree with this reasoning just let me know and I'll apply the rule directly to the progress items.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeonardoBraga I think the only one that is not working OK right now is the progress one, all the others should get the cursor: default if they are using spans.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpasero unless I'm missing something, in statusbarpart.css, the only selector that sets the cursor to default is .monaco-workbench > .part.statusbar > .statusbar-entry > span, which would not match .statusbar-item and even for .statusbar-entry, it would only match the first level spans.

Besides, having the cursor: default in the selector I suggested would even allow us to remove it from .statusbar-entry > span. Do you still prefer to proceed with the specific selector of the progress item?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeonardoBraga yeah fair enough.

width: 100%;
height: 22px;
font-size: 12px;
Expand Down