Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: sort actions should read out what action it performed #52452

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 20, 2018 · 3 comments
Assignees
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@AccessibilityTestingTeam-TCS

Environment Details:
VSCode Version : 1.24.0
OS Version : Win10
Additional Details:
Screenreader,NVDA[2018.2],JAWS[18.0.5038],MAS1.3.1
Repro Steps:
Launch VS Code while NVDA is ON.
Navigate to Settings icon in Activity Bar->Press Enter->Select "Keyboard Shortcuts" from dropdown.
3.Navigate to "Sort by precedence" button which is located inside the "Search keybindings" edit text field.
Actual:
NVDA is not reading any action performed by the "Sort by Precedence" button.
Same issue is observed in jaws
Expected:
NVDA should read actions performed on the page by the "Sort by Precedence" button.
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/Pages/browse-fixes.aspx
User Impact:
User will get confused about actions performed on the page.
MAS Reference:
MAS1.3.1: https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}
Attachment For Reference:
KeyBoardShorcutsScreenReader.pptx
Does this issue occur when all extensions are disabled?: Yes

@chrmarti chrmarti added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues keybindings-editor Keybinding editor issues labels Jun 21, 2018
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_KeyboardShortcuts_Screenreader: NVDA is not reading any action performed by the "Sort by Precedence" button. Extensions: sort actions should read out what action it performed Jul 4, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2018

Once the sort action is exectued a simple aria alert should do the trick -> assigning to July

@isidorn isidorn added this to the July 2018 milestone Jul 4, 2018
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jul 16, 2018
@RMacfarlane
Copy link
Contributor

Reopening because there is a typo in the label

precendence -> precedence

@RMacfarlane RMacfarlane reopened this Aug 2, 2018
@isidorn isidorn modified the milestones: July 2018, August 2018 Aug 2, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 27, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

5 participants