Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot remove all shell args from task #53306

Closed
chrmarti opened this issue Jun 29, 2018 · 0 comments
Closed

Cannot remove all shell args from task #53306

chrmarti opened this issue Jun 29, 2018 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Contributor

Issue Type: Bug

Verifying #50819

I can replace the top-level shell args with some other shell args on the task. Except: I cannot replace them with the empty list.

This task still prints the shell's version although its shell.args are empty, I'd expect it to print 'Hello':

  "options": {
    "shell": {
        "args": [
            "--version"
        ]
    }
  },
  "tasks": [
    {
      "type": "shell",
      "label": "echo",
      "command": "echo Hello",
      "options": {
        "shell": {
            "args": [
            ]
        }
      },
    }
  ]

VS Code version: Code - Insiders 1.25.0-insider (4991227, 2018-06-29T05:11:09.904Z)
OS version: Darwin x64 17.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.51GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron --extensions-dir /Users/chrmarti/Development/repos/tmp/ext --user-data-dir /Users/chrmarti/Development/repos/tmp/user
Screen Reader no
VM 0%
Extensions (1)
Extension Author (truncated) Version
debugger-for-chrome msj 4.7.0
@chrmarti chrmarti added the tasks Task system issues label Jun 29, 2018
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Jul 2, 2018
@dbaeumer dbaeumer added this to the Backlog milestone Jul 2, 2018
@alexr00 alexr00 assigned alexr00 and unassigned dbaeumer Oct 7, 2019
@alexr00 alexr00 modified the milestones: Backlog, October 2019 Oct 8, 2019
@JacksonKearl JacksonKearl added the verified Verification succeeded label Oct 30, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants