Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html] should disable ionic suggestions by default. Currently forces deprecated Ionic v1 suggestions in .html files while typing #53324

Closed
slimlime opened this issue Jun 29, 2018 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality html HTML support issues
Milestone

Comments

@slimlime
Copy link

slimlime commented Jun 29, 2018

Issue Type: Bug

When typing HTML, autocomplete suggests AngularJS v1 and Ionic v1 tags and attributes. As many of the suggestions are related to specific, old technologies, these should not be forced on users (esp. if they are not angular or ionic developers).

This ends up giving majority of Ionic developers errors on compile if they recklessly allow vs code to autocomplete an element such as the deprecated "ion-slide-box" instead of "ion-slides" (Ionic 3)

Expected behaviour:
In User Settings:

// Configures if the built-in HTML language suggests Ionic tags, properties and values.
"html.suggest.ionic": false,

Actual behaviour:

// Configures if the built-in HTML language suggests Ionic tags, properties and values.
"html.suggest.ionic": true,

This causes deprecated snippets/suggestions to display
image

It seems strange that an IDE specifically has angular and ionic suggestions forcibly enabled for html (would think this is a space for community extensions). Especially bothersome when some of the suggestions are deprecated and somehow overrode the ionic extensions I installed!

Pretty hard to track down this issue, hope the suggestion/snippet windows can show more information on where they originate on mouse hover as I have had similar issues in the past.

Encountered issue on VS Code 1.24.1, troubleshooted and also then installed a fresh copy of Insiders 1.25.0

VS Code version: Code - Insiders 1.25.0-insider (4991227, 2018-06-29T05:18:12.665Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 7.93GB (4.51GB free)
Process Argv \Code - Insiders.exe
Screen Reader no
VM 0%
Extensions: none
My first real issue submission Hope this helps!

Unfortunately, when I disable the html ionic suggestions, my extensions also seem to get disabled;
However, when I enabled the html ionic suggestions, the extensions are overwritten with the deprecated built-ins! A lose-lose situation!

@vscodebot
Copy link

vscodebot bot commented Jun 29, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@slimlime
Copy link
Author

slimlime commented Jun 29, 2018

Not a duplicate at all, @vscodebot! 😭

I have also submitted StackOverflow questions to my experiences the last few days.

@slimlime slimlime changed the title [html] disable ionic suggestions by default [html] disable ionic suggestions by default, currently forces deprecated Ionic v1 suggestions in .html files while typing Jun 30, 2018
@slimlime slimlime changed the title [html] disable ionic suggestions by default, currently forces deprecated Ionic v1 suggestions in .html files while typing [html] should disable ionic suggestions by default, currently forces deprecated Ionic v1 suggestions in .html files while typing Jun 30, 2018
@slimlime slimlime changed the title [html] should disable ionic suggestions by default, currently forces deprecated Ionic v1 suggestions in .html files while typing [html] should disable ionic suggestions by default. Currently forces deprecated Ionic v1 suggestions in .html files while typing Jun 30, 2018
@aeschli aeschli added this to the July 2018 milestone Jul 9, 2018
@aeschli aeschli added html HTML support issues feature-request Request for new features or functionality labels Aug 3, 2018
@aeschli aeschli closed this as completed in 4fa62b2 Aug 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality html HTML support issues
Projects
None yet
Development

No branches or pull requests

2 participants